BREAKING CHANGE: WaitForADDomain: Refactored the resource to handle timeout better #455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added function `Find-DomainController`. - Added function `Get-CurrentUser` (moved from the resource ADKDSKey).
- BREAKING CHANGE: Refactored the resource to handle timeout better and more correctly wait for a specific amount, and at the same time make the resource more intuitive to use. This change has replaced parameters in the resource (issue dsccommunity#343). - Now the resource can use built-in `PsDscRunAsCredential` instead of specifying the `Credential` parameter (issue dsccommunity#367). - New parameter `SiteName` can be used to wait for a domain controller in a specific site in the domain.
johlju
changed the title
johlju
added
breaking change
Codecov Report
@@ Coverage Diff @@
## dev #455 +/- ##
====================================
+ Coverage 97% 98% +<1%
====================================
Files 20 20
Lines 2703 2809 +106
Branches 10 10
====================================
+ Hits 2645 2761 +116
+ Misses 48 38 -10
Partials 10 10 |
johlju
commented
Aug 2, 2019
There was a problem hiding this comment.
Reviewed 23 of 23 files at r1, 7 of 7 files at r2.
Reviewable status:complete! all files reviewed, all discussions resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Find-DomainControlleris exported in the modulemanifest. When running
Import-Module -Name ActiveDirectoryDscthemodule will also import the nested module ActiveDirectoryDsc.Common.
It is exported so that the resource WaitForADDomain can reuse code
when running a background job to search for a domain controller.
Find-DomainController.Get-CurrentUser(moved from the resource ADKDSKey).more correctly wait for a specific amount of time, and at the same time
make the resource more intuitive to use. This change has replaced
parameters in the resource (issue #343).
PsDscRunAsCredentialinstead ofspecifying the
Credentialparameter (issue #367).SiteNamecan be used to wait for a domain controllerin a specific site in the domain.
This Pull Request (PR) fixes the following issues
Task list
Entry should say what was changed, and how that affects users (if applicable).
and comment-based help.
This change is